CI: Improve the Style Checks workflow to enforce underscores for both files and directories - #4876
Merged
Conversation
… files and directories
seisman
added
maintenance
yvonnefroehlich
left a comment
yvonnefroehlich
left a comment
Member
There was a problem hiding this comment.
Maybe we should use only underscores in the file names of this test images:
pygmt/tests/baseline/test_pygmtlogo_design_circle-horizontal.png
pygmt/tests/baseline/test_pygmtlogo_design_circle-vertical.png
pygmt/tests/baseline/test_pygmtlogo_design_hexagon-horizontal.png
pygmt/tests/baseline/test_pygmtlogo_design_hexagon-vertical.png
Member
Author
|
These names are auto-generated and we can't change them |
seisman
added
final review call
seisman
removed
the
final review call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3703, we added a step to check that all Python files and directories use underscores, not hyphens, in their names.
This PR extends it to check all files.
There are a few exceptions and are ignored: